Re: [PATCH 7/8] vcs-svn: convert REPORT_FILENO to an option

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jul 6, 2011, 10:09 UTC
Message-ID: <CALkWK0nO7dKkh-5kdLSwbncujOW4R-x_uRCXQcSbkhVP-qstVw@mail.gmail.com>
In-Reply-To: <1309715877-13814-8-git-send-email-divanorama@gmail.com>

Hi again,

Dmitry Ivankov writes:

Show 14 quoted lines

> svn-fe needs to read fast-import's responses to "ls" and "cat-blob".
> These come through a file descriptor number 3.
>
> Sometimes it is easier to setup variable fd than a fixed one. It is
> the case with pipe() call and even more fd=3 can be already taken.
> On Windows file descriptors are not by default inherited by a child
> process, nor there is an option to setup descriptors other than
> standard stdin, stdout, stderr at a process creation time.
>
> Add an option for this file descriptor number in vcs-svn/ and svn-fe,
> add a simple test for it.
>
> To be used like following:
> $ svn-fe --read-blob-fd=7 ... 7<somewhere

Except for the fact that you're changing the API to accommodate an extra option as I already pointed out earlier, I like this patch. This was one of the things that I'd wanted to do myself, but never actually got around to doing.

Thanks for working on this.

-- Ram