Re: [PATCH 2/2] sha1_name: fix error message for @{<N>}, @{<date>}

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 24, 2013, 17:24 UTC
Message-ID: <CALkWK0moMOBUZqqSe521qfa7q8xe0Z5sN10ZRQpPaTu8EuxuDw@mail.gmail.com>
In-Reply-To: <7vd2sgb9r8.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> What is this meant to update?  I recall rewriting this part on
> purpose.

I was being verbose to show that I handle the detached HEAD case too, which I missed last time.

> Even though it appears unusual and invites confusion, it is very
> consistent to say '' when the user asks for @... as we say 'master'
> when the user asks for master@...; "inconsistent" is a very bad
> label for it.

The inconsistency refers to these two:

>>   # on branch master
>>   $ git show @{10000}
>>   fatal: Log for '' only has 7 entries.

>>   # detached HEAD case
>>   $ git show @{10000}
>>   fatal: Log for '' only has 2005 entries.

Is the commit message unclear?