git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/7] rebase: write better reflog messages

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 24, 2013, 08:12 UTC
Message-ID
<CALkWK0meLtmSFNSXPxkz4dnXQ_wgNPdUbB-7TL3iqL0JOg5Qmw@mail.gmail.com>
In-Reply-To
<7vtxkoc557.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> So you are forcing people to maintain _two_ variables, instead of
> just _one_, without making anything simpler.
>
> What's so hard to understand why it is a wrong design?

Fine. Let's say I buy your argument about one-variable versus two-variables: how do you solve the existing problems that are solved by overriding GIT_REFLOG_ACTION that I pointed out?

> If you truly think this is "inconsequential", that unfortunately
> convinces me that you cannot yet be trusted enough to give you
> latitude to design interfaces that span multiple programs X-<.

*shrug* I certainly don't think one-variable versus two-variables warrants this much discussion.

I don't have anything to win or lose: I designed a solution to the problem which I think is reasonable; you don't. Fine. Show me an alternative that doesn't involve rewriting half of the rebase infrastructure in a series that fixes checkout-dash.

Previous: Junio C HamanoNext: Ramkumar Ramachandra
Message 13 of 14 in “Re-roll rr/rebase-checkout-reflog”
  1. 0/7 Re-roll rr/rebase-checkout-reflogRamkumar Ramachandra, Jun 19, 2013
  2. 1/7 t/t7512-status-help: test "HEAD detached from"Ramkumar Ramachandra, Jun 19, 2013
  3. 2/7 wt-status: remove unused field in grab_1st_switch_cbdataRamkumar Ramachandra, Jun 19, 2013
  4. 3/7 t/t2012-checkout-last: test "checkout -" after a rebaseRamkumar Ramachandra, Jun 19, 2013
  5. Johannes SixtJun 19, 2013
  6. Ramkumar RamachandraJun 19, 2013
  7. 4/7 status: do not depend on rebase reflog messagesRamkumar Ramachandra, Jun 19, 2013
  8. 5/7 checkout: respect GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 19, 2013
  9. 6/7 rebase: write better reflog messagesRamkumar Ramachandra, Jun 19, 2013
  10. Junio C HamanoJun 24, 2013
  11. Ramkumar RamachandraJun 24, 2013
  12. Junio C HamanoJun 24, 2013
  13. Ramkumar RamachandraJun 24, 2013
  14. 7/7 rebase -i: write better reflog messagesRamkumar Ramachandra, Jun 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.