Re: [PATCH] Add new git-cc-cmd helper to contrib

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Nov 11, 2012, 17:18 UTC
Message-ID: <CALkWK0ksDBbWfxbT=PbKiWaC87vghTADPqcy+ujgJ9iZOVZv0w@mail.gmail.com>
In-Reply-To: <1352653804-2203-1-git-send-email-felipe.contreras@gmail.com>

Hi Felipe,

Felipe Contreras wrote:

Show 6 quoted lines

> The code finds the changes in each commit in the list, runs 'git blame'
> to see which other commits are relevant to those lines, and then adds
> the author and signer to the list.
>
> Finally, it calculates what percentage of the total relevant commits
> each person was involved in, and if it passes the threshold, it goes in.

This is very cool.

Show 7 quoted lines

> diff --git a/contrib/cc-cmd/git-cc-cmd b/contrib/cc-cmd/git-cc-cmd
> new file mode 100755
> index 0000000..17b14d4
> --- /dev/null
> +++ b/contrib/cc-cmd/git-cc-cmd
> @@ -0,0 +1,186 @@
> +#!/usr/bin/env ruby

Just out of curiosity, why didn't you write it in Python? (I noticed that you wrote remote-hg and remote-bzr in Python, and assumed that it was your preferred language)

> +$alias_file = "~/.mutt/aliases"

Please read sendemail.aliasfiletype instead of assuming mutt.

Ram