Re: [PATCH v2 2/3] for-each-ref: introduce %(upstream:track[short])

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Nov 14, 2013, 06:53 UTC
Message-ID: <CALkWK0kSuSLjmShPx6cibysjvhrU0xqBvm=ivGLCn3L1kTDBFw@mail.gmail.com>
In-Reply-To: <xmqqk3gcdr6z.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> builtin/for-each-ref.c: In function 'populate_value':
> builtin/for-each-ref.c:701:13: error: 'refname' may be used uninitialized in this function [-Werror=uninitialized]

In my defense, the gcc on my end (4.8.2) doesn't seem to complain. Are you using extra cflags?

However, I do get the following compile warnings:

wt-status.c: In function ‘wt_status_print_unmerged_header’:
wt-status.c:187:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, c, "");
  ^
wt-status.c: In function ‘wt_status_print_cached_header’:
wt-status.c:203:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, c, "");
  ^
wt-status.c: In function ‘wt_status_print_dirty_header’:
wt-status.c:222:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, c, "");
  ^
wt-status.c: In function ‘wt_status_print_other_header’:
wt-status.c:234:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, c, "");
  ^
wt-status.c: In function ‘wt_status_print_trailer’:
wt-status.c:239:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
  ^
wt-status.c: In function ‘wt_status_print_other’:
wt-status.c:767:2: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
  status_printf_ln(s, GIT_COLOR_NORMAL, "");
  ^
wt-status.c: In function ‘wt_status_print_tracking’:
wt-status.c:827:3: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
   fprintf_ln(s->fp, "");
   ^
wt-status.c: In function ‘wt_status_print’:
wt-status.c:1243:3: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
   status_printf(s, color(WT_STATUS_HEADER, s), "");
   ^
wt-status.c:1256:3: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
   status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
   ^
wt-status.c:1258:3: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
   status_printf_ln(s, color(WT_STATUS_HEADER, s), "");
   ^
wt-status.c:1275:4: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
    status_printf_ln(s, GIT_COLOR_NORMAL, "");
    ^
builtin/commit.c: In function ‘prepare_to_commit’:
builtin/commit.c:808:4: warning: zero-length gnu_printf format string
[-Wformat-zero-length]
    status_printf_ln(s, GIT_COLOR_NORMAL, "");
    ^