Re: [PATCH] t3400 (rebase): add failing test for a peculiar rev spec

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Apr 19, 2013, 07:43 UTC
Message-ID: <CALkWK0=RDCCSxOJ2TU4=tniSRTg9VJohJ8Pf6uN9E=fd3jg=_Q@mail.gmail.com>
In-Reply-To: <7vmwsv94jo.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 11 quoted lines

>         peel_committish () {
>                 case "$1" in
>                 :/*)
>                         peeltmp=$(git rev-parse --verify "$1") &&
>                         git rev-parse --verify "$peeltmp^0"
>                         ;;
>                 *)
>                         git rev-parse --verify "$1^0"
>                         ;;
>                 esac
>         }

Thanks. Yeah, that's the obvious "hack solution": special handling for refspecs of the kind :/text. Will write a patch for it soon (currently struggling to complete rebase.autostash). In the meantime, please queue this patch.

I'm more interested in knowing what you think of my first point: is :/text fundamentally broken, as it can't be combined with other operators like the other rev specs can? If so, how do you think we should fix it?