Re: [PATCH 2/5] svn-fe: allow svnadmin instead of svnrdump in svn helper

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Jul 6, 2011, 10:12 UTC
Message-ID: <CALkWK0=Lqg4vMOdD8zah5RM3GOkBorJ80kBfs4BHEjZrG+rNVg@mail.gmail.com>
In-Reply-To: <1309884350-13415-3-git-send-email-divanorama@gmail.com>

Hi,

Dmitry Ivankov writes:

Show 8 quoted lines

> svnrdump produces the same stream as svnadmin dump. svnrdump is able
> to do it via any svn remote protocol while svnadmin needs access to
> the repository filesystem and can't produce subdirectory dumps.
> But svnrdump is a newer tool and may be unavailable on some systems.
>
> Try to use svnadmin dump for file:// repository urls if there is no
> svnrdump in the PATH. First of all this is to be used in tests, where
> the repository is indeed local most of the time.

svnrdump's output is not identical to svnadmin's output. You'd perhaps want to document the differences, and the impact they might have?

Show 14 quoted lines

> diff --git a/contrib/svn-fe/git-remote-svn-alpha b/contrib/svn-fe/git-remote-svn-alpha
> index 61c9b07..84d841e 100755
> --- a/contrib/svn-fe/git-remote-svn-alpha
> +++ b/contrib/svn-fe/git-remote-svn-alpha
> @@ -12,10 +12,32 @@ usage () {
>        exit 129
>  }
>
> +try_svnrdump () {
> +       command -v svnrdump >/dev/null &&
> +       echo "svnrdump dump --non-interactive --username=Guest --password= \
> +               --quiet --incremental" ||
> +       true
> +}

I saw this '--username', '--password' in other patches too. I'm probably missing context, but I'm curious to know why this is required and what you're planning to do to fix it in the future.

Thanks.

-- Ram