Re: [PATCH] diff: prevent pprint_rename from underrunning input

From

Antoine Pelisse <apelisse@gmail.com>

Date

Feb 27, 2013, 13:27 UTC

Message-ID

<CALWbr2zq9WzQiry0U+G0mpQOqd838r8+GYJ91601MBMp=D94xA@mail.gmail.com>

In-Reply-To

<7vsj4ilphz.fsf@alter.siamese.dyndns.org>

>> The logic described in d020e27 (diff: Fix rename pretty-print when
>> suffix and prefix overlap, 2013-02-23) is wrong: The proof in the
>> comment is valid only if both strings are the same length.  *One* of
>> old/new can reach a-1 (b-1, resp.) if 'a' is a suffix of 'b' (or vice
>> versa).

> Thanks.  I was also having hard time convincing myself why that -1
> does not under-run yesterday.
>
> Will queue.

Thanks