Re: What's cooking in git.git (Dec 2012, #08; Mon, 31)
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Jan 1, 2013, 15:29 UTC
- Message-ID
- <CALWbr2y6M7fZgQb2dizgcBZHTL=TudSc6c-DUOicKHvwahtm9g@mail.gmail.com>
- In-Reply-To
- <7vk3rxd9yo.fsf@alter.siamese.dyndns.org>
> * ap/status-ignored-in-ignored-directory (2012-12-26) 1 commit > - wt-status: Show ignored files in untracked dirs > > A topic still in flux; will be redone.
I've already redone this part sending two patches (one with the fix, and one with some tests for each individual use-case) that you probably missed. Here are the message ids: - <1356878341-12942-1-git-send-email-apelisse@gmail.com> - <1356878341-12942-2-git-send-email-apelisse@gmail.com>
Show 17 quoted lines
> * ap/log-mailmap (2012-12-27) 10 commits > - log --use-mailmap: optimize for cases without --author/--committer search > - log: add log.mailmap configuration option > - log: grep author/committer using mailmap > - test: Add test for --use-mailmap option > - log: Add --use-mailmap option > - pretty: Use mailmap to display username and email > - mailmap: Add mailmap structure to rev_info and pp > - mailmap: Simplify map_user() interface > - mailmap: Remove buffer length limit in map_user > - Use split_ident_line to parse author and committer > (this branch is used by jc/mailmap.) > > Clean up various codepaths around mailmap and teach the "log" > machinery to use it. > > Will merge to 'next'.
I'm not sure that should be merged to next yet. I've thought of another optimization that will require another preparatory step. Here is the idea:
- Create some string_list_lookup_extended with a n parameter (size of the string to match) and a case parameter (to allow strncasecmp() the strings). - Re-re-factor map_user() to take/return pointers instead of strbufs to avoid a bunch of copies. (that is pointless without the former point).
The whole idea would be to avoid a bunch of copies: one for lowering the email, the other for adding '\0' at the end of name before running string_list_lookup().
Cheers,