Re: [PATCH 5/5] log: Add --use-mailmap option
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Dec 12, 2012, 11:58 UTC
- Message-ID
- <CALWbr2xmRVS9m623yrxY88Ftaen_B8Tb2vd+VxhYV1ceAmbDSg@mail.gmail.com>
- In-Reply-To
- <1355264493-8298-6-git-send-email-apelisse@gmail.com>
On Tue, Dec 11, 2012 at 11:21 PM, Antoine Pelisse <apelisse@gmail.com> wrote:
> Add the --use-mailmap option to log commands. It allows > to display names from mailmap file when displaying logs, > whatever the format used.
The question is which log commands actually ? Shouldn't we put the option in revision.c::handle_revision_opt instead ? My opinion is that it belongs to 'Commit Formatting'. It would also make sense to be able to use '--use-mailmap' when running format-patch for example.
Also, I've noticed that my series break some tests (linked with format-patch BTW). I fixed that and re-ran all tests successfully. I will resubmit it later.