git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] remote-hg: allow invalid bookmarks in a few edge cases

From
Antoine Pelisse <apelisse@gmail.com>
Date
Mar 19, 2014, 15:18 UTC
Message-ID
<CALWbr2xa9pJ5wXJGB8Q6ZL9CWsVCPdhW5n-VbGZpTsmgjd6XhQ@mail.gmail.com>
In-Reply-To
<CDB4DDFC-FF7F-4BE0-A0B5-0933A506F690@quendi.de>
On Wed, Mar 19, 2014 at 4:00 PM, Max Horn <max@quendi.de> wrote:
Show 8 quoted lines
>> Thank you for working on this.
>> I believe it would be fair that you forget about patch 1/3 as you fix
>> it in this patch (2/3).
>> Also, I think it would be best NOT to integrate a patch (mine) that
>> breaks a test, as it
>> would make bisect harder to use.
>
> OK, makes sense. I didn't want to step on anybodies feet by hijacking previously made work (however small or big it might be -- I've been burned by this before). Anyway, so I'll squash the first two commits together (or all three even?), and edit the message. But I'd like to properly attribute that you discovered the issue, so perhaps I can add something like "Reported-by: Antoine Pelisse" or so?

Yes, I think you can squash all three commits into one, and use the reported-by line that you mentioned.

Thanks, Antoine

Previous: Max HornNext: Max Horn
Message 5 of 6 in “remote-hg: do not fail on invalid bookmarks”
  1. 1/3 remote-hg: do not fail on invalid bookmarksMax Horn, Mar 19, 2014
  2. 2/3 remote-hg: allow invalid bookmarks in a few edge casesMax Horn, Mar 19, 2014
  3. Antoine PelisseMar 19, 2014
  4. Max HornMar 19, 2014
  5. Antoine PelisseMar 19, 2014
  6. 3/3 remote-hg: add test cases for null bookmarksMax Horn, Mar 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.