git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/10] reroll of ap/log-mailmap

From
Antoine Pelisse <apelisse@gmail.com>
Date
Jan 8, 2013, 07:27 UTC
Message-ID
<CALWbr2w8z2iVx2PxM2sn3yDQzB5rTXc4EuZD9GCKSCofHzEzLQ@mail.gmail.com>
In-Reply-To
<1357603821-8647-1-git-send-email-gitster@pobox.com>
On Tue, Jan 8, 2013 at 1:10 AM, Junio C Hamano <gitster@pobox.com> wrote:
> This is a reroll of the previous series Antoine posted on Saturday.
Thanks a lot for the reroll Junio
Show 29 quoted lines
> A new patch "string-list: allow case-insensitive string list"
> teaches the string-list API that some string lists can be sorted
> case insensitively (actually, you can feed any custom two string
> comparison functions).
>
> The string_list_lookup_extended() function introduced by the
> previous series has been discarded.  Instead, the third patch
> "mailmap: remove email copy and length limitation" introduces a
> helper function that takes a <char *, size_t> key that is not NUL
> terminated to look for a matching item in a string list, and uses
> that to update map_user() function, together with the fourth
> patch "mailmap: simplify map_user() interface".
>
> All other patches are unmodified from Antoine's series (modulo
> wording tweaks here and there).
>
> Antoine Pelisse (9):
>   Use split_ident_line to parse author and committer
>   mailmap: remove email copy and length limitation
>   mailmap: simplify map_user() interface
>   mailmap: add mailmap structure to rev_info and pp
>   pretty: use mailmap to display username and email
>   log: add --use-mailmap option
>   test: add test for --use-mailmap option
>   log: grep author/committer using mailmap
>   log: add log.mailmap configuration option
>
> Junio C Hamano (1):
>   string-list: allow case-insensitive string list

I think this one is missing (and I forgot to reroll it before): log --use-mailmap: optimize for cases without --author/--committer search

Show 17 quoted lines
>
>  Documentation/config.txt  |   4 +
>  Documentation/git-log.txt |   5 ++
>  builtin/blame.c           | 183 ++++++++++++++++++++++------------------------
>  builtin/log.c             |  16 +++-
>  builtin/shortlog.c        |  54 ++++----------
>  commit.h                  |   1 +
>  log-tree.c                |   1 +
>  mailmap.c                 |  94 +++++++++++++++---------
>  mailmap.h                 |   4 +-
>  pretty.c                  | 114 ++++++++++++++++-------------
>  revision.c                |  54 ++++++++++++++
>  revision.h                |   1 +
>  string-list.c             |  17 ++++-
>  string-list.h             |   4 +
>  t/t4203-mailmap.sh        |  56 ++++++++++++++
>  15 files changed, 379 insertions(+), 229 deletions(-)
Have you been able to measure a speed increase due to less copies ?

Thanks, Antoine

Previous: Junio C HamanoNext: Junio C Hamano
Message 16 of 18 in “reroll of ap/log-mailmap”
  1. 00/10 reroll of ap/log-mailmapJunio C Hamano, Jan 8, 2013
  2. 01/10 string-list: allow case-insensitive string listJunio C Hamano, Jan 8, 2013
  3. René ScharfeJan 10, 2013
  4. 02/10 Use split_ident_line to parse author and committerJunio C Hamano, Jan 8, 2013
  5. 03/10 mailmap: remove email copy and length limitationJunio C Hamano, Jan 8, 2013
  6. Antoine PelisseJan 9, 2013
  7. Junio C HamanoJan 9, 2013
  8. Junio C HamanoJan 9, 2013
  9. 04/10 mailmap: simplify map_user() interfaceJunio C Hamano, Jan 8, 2013
  10. 05/10 mailmap: add mailmap structure to rev_info and ppJunio C Hamano, Jan 8, 2013
  11. 06/10 pretty: use mailmap to display username and emailJunio C Hamano, Jan 8, 2013
  12. 07/10 log: add --use-mailmap optionJunio C Hamano, Jan 8, 2013
  13. 08/10 test: add test for --use-mailmap optionJunio C Hamano, Jan 8, 2013
  14. 09/10 log: grep author/committer using mailmapJunio C Hamano, Jan 8, 2013
  15. 10/10 log: add log.mailmap configuration optionJunio C Hamano, Jan 8, 2013
  16. Antoine PelisseJan 8, 2013
  17. Junio C HamanoJan 8, 2013
  18. Junio C HamanoJan 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.