Re: [PATCH] Geolocation support

From: Antoine Pelisse <apelisse@gmail.com>
Date: May 23, 2013, 09:52 UTC
Message-ID: <CALWbr2w3=DTAMkFtJoLF1_X46fefpEq2WtTb7HGiTiOExFHG3w@mail.gmail.com>
In-Reply-To: <CALkWK0kHEDn4Wt3Y+XUE59_9ZDf504yopMp9QtBUk49Sd+EXbg@mail.gmail.com>

On Thu, May 23, 2013 at 10:45 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 12 quoted lines

> Alessandro Di Marco wrote:
>> this is a hack I made a couple of years ago in order to store my current
>> location in git commits (I travel a lot and being able to associate a
>> place with the commit date helps me to quickly recover what were doing
>> at that time). Long story short, the screeenshot at
>> http://tinypic.com/r/wars40/5 shows the new gitk interface once this
>> patch has been integrated. Geolocation is controlled by two envvars
>> GIT_AUTHOR_PLACE and COMMITTER_PLACE, respectively. You can set them via
>> something like this:
>
> Obviously very interesting.  Now, how do we mainline (parts of) this
> feature?  I'll raise some questions here:

I'm really not convinced this kind of changes should make it into Junio's tree (of course, he's the only one to decide). I really believe this is a very specific solution to a very specific problem (that is not for me to judge if the problem is real). Bloating the commit object with this kind of information doesn't feel like a good idea. I think it could be nice to provide a simple shell script to build the location, callable from a post-commit hook, to construct a "geolocation" note. Gitk could be programmed to read the notes to get the location, but once again, I'm not sure it should be mainlined.