Re: [PATCH 3/3] git submodule update should give notice when run without init beforehand

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Sep 18, 2013, 10:12 UTC
Message-ID: <CALUzUxoFLOP=-ub_VYr6LqRYQXOO7Tf1oP95mxuYZo-8_dxAZw@mail.gmail.com>
In-Reply-To: <52373AA2.9050807@web.de>

On Tue, Sep 17, 2013 at 1:06 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:

Thanks Jens for having a look!

Show 7 quoted lines

> Am 15.09.2013 19:38, schrieb Tay Ray Chuan:
>> When 'update' is run with no path in a repository with uninitialized
>> submodules, the program terminates with no output, and zero status code.
>> Be more helpful to users by mentioning this.
>
> [snip] it would be rather nasty to error out on every submodule
> update.

Just to be sure we're on the right page, with this patch, the 'update' command still exits with status code zero (non-error), so this patch doesn't make it error out.

> After the 'autoinit' configuration (which lets upstream hint that
> certain submodules should be initialized on clone) has materialzed we
> might want to enable this error for these specific submodules.

That's cool, I'm looking forward to this. Could you point me to somewhere detailing this?

But in the meantime, on top of the advice.* config, how about having a submodule.<name>.ignoreUninit config to disable the message on a per-submodule basis?

> But in
> any case the error message should contain a hint on how you can get
> rid of the error in case you know what you are doing ;-).

The message does mention that you can throw in an --init to fix the problem. This "hint" is similar to what git-submodule prints when a <path> is passed (see region at line 807).

-- 
Cheers,
Ray Chuan