git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Weird behavior with git grep --recurse-submodules

From
BWBrandon Williams <bwilliamseng@gmail.com>
Date
Aug 3, 2019, 23:39 UTC
Message-ID
<CALN-EhTugXw6J7eA=JznGGuk7d5FfMu7s2p44OYKZgOqaN1oOA@mail.gmail.com>
In-Reply-To
<CAHd-oW61RFCySF+gUj8iYuV6afEoD0RD9oYE+N6rYd7rv3J2nA@mail.gmail.com>

On Mon, Jul 29, 2019 at 1:27 PM Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:

Show 13 quoted lines
>
> On Tue, Jul 16, 2019 at 3:09 PM Daniel Zaoui <jackdanielz@eyomi.org> wrote:
> >
> > Hi Matheus,
>
> Hi, Daniel
>
> I'm sorry, your last message went to my spam folder for some reason :(
>
> > Thank you for your response.
> >
> > I really hope the change Brandon made is not a project decision. At least, it does seem to me like a bug.
> >

Since I'm the one who originally implemented the --recurse-submodules feature to git grep back in 0281e487f (grep: optionally recurse into submodules, 2016-12-16) and then subsequently changed the implementation to do the recursion in process in f9ee2fc ("grep: recurse in-process using 'struct repository'", 02-08-2017) I can say it was definitely a bug I introduced during the conversion as I don't believe I would have intended to introduce that change of behavior (especially without documenting it).

Show 10 quoted lines
> > How do you recommend me to solve this issue? Is there some place where I can check if some bug ticket has been created on this matter? I didn't find anything in the mailing list archives about this.
>
> I think I manage to solve the bug with this[1] patch. I'm going to ask
> my GSoC mentors to take a look and then I'll send it to the mailing
> list :) Thanks for reporting it.
>
> Best,
> Matheus
>
> [1]: https://github.com/matheustavares/git/commit/37aeeb3ab86b5dfebfaafeb98d34e379341a529d
Previous: Matheus Tavares
Message 14 of 14 in “Weird behavior with git grep --recurse-submodules”
  1. Daniel ZaouiJul 8, 2019
  2. Matheus Tavares BernardinoJul 10, 2019
  3. Johannes SchindelinJul 10, 2019
  4. Daniel ZaouiJul 16, 2019
  5. Matheus Tavares BernardinoJul 29, 2019
  6. [GSoC][PATCH] grep: fix worktree case in submodulesMatheus Tavares, Jul 30, 2019
  7. Junio C HamanoJul 30, 2019
  8. Christian CouderJul 30, 2019
  9. Junio C HamanoJul 31, 2019
  10. Matheus Tavares BernardinoAug 1, 2019
  11. Matheus Tavares BernardinoJul 30, 2019
  12. [GSoC][PATCH v2] grep: fix worktree case in submodulesMatheus Tavares, Jul 31, 2019
  13. [GSoC][PATCH v3] grep: fix worktree case in submodulesMatheus Tavares, Aug 1, 2019
  14. Brandon WilliamsAug 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.