Re: [PATCH v3 0/2] merge-recursive: option to disable renames
- From
- Felipe Gonçalves Assis <felipeg.assis@gmail.com>
- Date
- Feb 17, 2016, 03:38 UTC
- Message-ID
- <CALMa68oy2i6GeiUS1MLodAJ__TsqDzbRWcFVY2xdZKcoONKvzA@mail.gmail.com>
- In-Reply-To
- <CAPig+cRhbCRJhrOFcjY2avFZ0rQgCP-JT-6RTCiihOQB8nWeMw@mail.gmail.com>
On 16 February 2016 at 23:37, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 11 quoted lines
> On Tue, Feb 16, 2016 at 8:11 PM, Felipe Gonçalves Assis > <felipeg.assis@gmail.com> wrote: >> No more renames option. rename-threshold enables renames. > > Can you add some tests? Off the top of my head, I'd expect to see at > least three new tests: > > 1. --no-renames works as expected > 2. last wins in "--no-renames --rename-threshold=x" > 3. last wins in "--rename-threshold=x --no-renames" >
Sure.
Just a heads up: For the next three days I will have very little time, so I will start tackling this on the weekend. I submitted a fourth version of the patch without the tests, so that this part of the work can proceed in parallel.
Thanks, Felipe