git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: add failing tests for case-folding p4d

From
Lex Spoon <lex@lexspoon.org>
Date
Apr 28, 2015, 23:01 UTC
Message-ID
<CALM2Sna0OqxYWzEj94SY61ZsL8cB+SyuiJ0EsAzq+kbiw87QLQ@mail.gmail.com>
In-Reply-To
<1430212081-16146-2-git-send-email-luke@diamand.org>

The last comment in the test took me a minute to decipher. I would suggest "no repo path called LC" instead of "no repo called LC". Also, it would have helped me to either have a little comment on the "UC" version of the test, or to make the previous comment a little more neutral so that it will apply to both test cases.

Otherwise, while I am not a regular maintainer of this code, the patch does LGTM. Certainly it's good to have more test coverage.

For the underlying problem, I haven't thought about it very much, but it looks like a plausible first step might be to simply probe the given file name and see if it comes back the same way. If it comes back differently, then maybe the command should abort?

What a tough problem all around...
Lex
Previous: Luke DiamandNext: Luke Diamand
Message 3 of 5 in “git-p4: add failing tests for case-folding in p4d”
  1. git-p4: add failing tests for case-folding in p4dLuke Diamand, Apr 28, 2015
  2. git-p4: add failing tests for case-folding p4dLuke Diamand, Apr 28, 2015
  3. Lex SpoonApr 28, 2015
  4. Luke DiamandApr 29, 2015
  5. Luke DiamandApr 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.