Re: [PATCH 4/6] t/t5528-push-default: generalize test_push_*
- From
Johan Herland <johan@herland.net>
- Date
- Jun 24, 2013, 08:33 UTC
- Message-ID
- <CALKQrge4Nac4nk1RSnOFwE4-BNtHRNDSZHh9ihPY7ERd5jQ2Ng@mail.gmail.com>
- In-Reply-To
- <7v7ghkdl2p.fsf@alter.siamese.dyndns.org>
On Mon, Jun 24, 2013 at 9:28 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Johan Herland <johan@herland.net> writes:
>
>>> + git --git-dir="${3:-repo1}" log -1 --format='%h %s' "$2" >actual &&
>>
>> Isn't ${3:-repo1} a bashism?
>
> I do not think so. But now I looked at it again, I think I would
> use ${3-repo1} form in this case myself. No caller passes an empty
> string to the third place.Ok, I have to admit that I'm not at all sure where the line between sh and bash goes when it comes to ${magic}... Is there any good documentation on what is in sh and what is not?
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net c