Re: [PATCH 1/2] t3312-notes-empty: Test that 'git notes' removes empty notes by default

From

Johan Herland <johan@herland.net>

Date

Nov 5, 2014, 08:32 UTC

Message-ID

<CALKQrgdtvfZ+LFn+VSE-yjvJf1zwTZdEov48eDbhvx0JWHpeug@mail.gmail.com>

In-Reply-To

<CAPig+cT4-1bY5tq8KioC8Js3ZUfZCuFEwOZMeoPW4M_brK+QXw@mail.gmail.com>

On Wed, Nov 5, 2014 at 5:10 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

[...]

> write_script() would allow you to drop the #!/bin/sh and chmod lines.

[...]

> Rather than hard-coding this output, generating it would make the test
> script less fragile:
>
>     git log -1 >expect_missing

[...]

> Each -c/-C case fails for me when trying to read $empty_object. For example:
>
> fatal: Failed to read object 'e69de29bb2d1d6434b8b29ae775ad8c2e48c5391'.
> not ok 5 - 'git notes add -c "$empty_blob"' removes empty note

These are all fixed in the re-roll.

Thanks for the feedback!

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net