Re: git-note -C changes commit type?

From: Johan Herland <johan@herland.net>
Date: Feb 12, 2014, 09:50 UTC
Message-ID: <CALKQrgdnGhc-y3WMf+zej4M+O4NMhLKusE-N6dX_xKVViZmQzA@mail.gmail.com>
In-Reply-To: <xmqqvbwlnqi1.fsf@gitster.dls.corp.google.com>

On Wed, Feb 12, 2014 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Johan Herland <johan@herland.net> writes:
>> There is currently no way the "git notes" commands will allow you to
>> store the 3d7de37 commit object directly as a note. There is also
>> (AFAICS) no easy workaround (git fast-import could've been a
>> workaround if it did not already require the first N/notemodify
>> argument to be a blob object). The best alternative, off the top of my
>> head, would be to write your own program using the notes.h API to
>> manipulate the notes tree directly (or - suboptimally - use other
>> low-level Git operations to do the same).
>
> Even worse. I do not think such a non-blob object in the notes tree
> does not participate in the reachability at all, so you won't be
> able to fetch "refs/notes/whatever" and expect to get a useful
> result.

s/non-blob/non-(blob-or-tree)/

Any object type that is deemed reachable by reference from a regular git tree object will also be usable (as far as reachability goes) in a notes tree.

> I do not think storing the raw bits of commit object as a
> blob in the notes tree is useful behaviour, either.  The command
> probably should refuse to get anything non-blob via that option.

Patch coming up...

> Perhaps the notes entry should just note the object name of whatever
> commit it wants to refer to in a *blob*?

Agreed.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net