git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

From
Johan Herland <johan@herland.net>
Date
Aug 22, 2015, 16:30 UTC
Message-ID
<CALKQrgcvRvs8wLy-O2eZZg9iMG2T7coFMoFwmDu3nmAXHhdW1w@mail.gmail.com>
In-Reply-To
<0LZlZ2-1Z1Zyn1mzk-00lZ3Z@mail.gmx.com>

On Sat, Aug 22, 2015 at 5:14 PM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 12 quoted lines
> The `format_display_notes()` function clearly assumes that the data
> structure holding the notes has been initialized already, i.e. that the
> `display_notes_trees` variable is no longer `NULL`.
>
> However, when there are no notes whatsoever, this variable is still
> `NULL`, even after initialization.
>
> So let's be graceful and just return if that data structure is `NULL`.
>
> Reported in https://github.com/msysgit/git/issues/363.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Johan Herland <johan@herland.net>
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Johannes SchindelinNext: Jeff King
Message 2 of 7 in “Fix `git rev-list --show-notes HEAD` when there are no notes”
  1. Fix `git rev-list --show-notes HEAD` when there are no notesJohannes Schindelin, Aug 22, 2015
  2. Johan HerlandAug 22, 2015
  3. Jeff KingAug 23, 2015
  4. rev-list: make it obvious that we do not support notesJeff King, Aug 23, 2015
  5. Johannes SchindelinAug 24, 2015
  6. Jeff KingAug 24, 2015
  7. Johannes SchindelinAug 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.