Re: [GSoC][RFC][PATCH 1/2] STRBUF_INIT_CONST: a new way to initialize strbuf
- From
Robear Selwans <rwagih.rw@gmail.com>
- Date
- Feb 21, 2020, 05:21 UTC
- Message-ID
- <CALH1-XoDm26QMQDgA0zKmSMPnbDxJCOF6k2xyyeePL15APV68w@mail.gmail.com>
- In-Reply-To
- <113d4221-d7bd-cf0c-ebfc-1fc08442c303@web.de>
On Thu, Feb 20, 2020 at 8:49 PM René Scharfe <l.s.r@web.de> wrote:
> > Could you perhaps include a patch that makes use of it in this series, > to highlight its benefits?
Well to begin with, I'm actually doing this in response to this issue [https://github.com/gitgitgadget/git/issues/398]. The issue was created because of the following mail thread, though. [https://public-inbox.org/git/20180601200146.114919-1-sbeller@google.com/] To be honest, I'm not entirely sure about how making these changes would help, as my experience is still quite limited. But from what I've read, I think the main use-case would be using const `strbuf`s to avoid memory leaks when dealing with config strings.