Re: [PATCH/RFC] Fix the result of "git grep -l -C <num>"
- From
- Albert Yale <surfingalbert@gmail.com>
- Date
- Jan 23, 2012, 17:10 UTC
- Message-ID
- <CALEc4zGV6Oo-WR0vPE6=oEmm=fo4dd=nyBWFuK1oU7rmF9K41A@mail.gmail.com>
- In-Reply-To
- <8762g2ieq0.fsf@thomas.inf.ethz.ch>
You're right. This solution is incomplete. It needs to take into account "opt.unmatch_name_only", and possibly other states. I'm open for suggestions.
I've just posted Version 2 of this patch.
As for creating a test, I'm unfamiliar with the testing procedure for git-core. A "how to" in the "Documentation" folder would be very useful in that regard.
Albert
On Mon, Jan 23, 2012 at 11:08 AM, Thomas Rast <trast@student.ethz.ch> wrote:
Show 19 quoted lines
> Albert Yale <surfingalbert@gmail.com> writes:
>
>> When combining "git grep -l" with "-C <num>",
>> the first result is omitted.
> [...]
>> For example, if the following command should output a list of 3
>> different files (a.txt, b.txt, c.txt):
>>
>> $ git grep -l -C 1 albert_yale
>> b.txt
>> c.txt
>
> Nice catch. Can you add a test?
>
> Is -l the only option affected? Why isn't, for example, -L?
>
> --
> Thomas Rast
> trast@{inf,student}.ethz.ch