(no subject)
- From
Rohit Ashiwal <rohit.ashiwal265@gmail.com>
- Date
- Feb 28, 2019, 10:43 UTC
- Message-ID
- <CAL7ArXp0xJx4DLZ7jM78SRFPGE0Ph9itrZpV0LtQYhbART1s5g@mail.gmail.com>
Hey Duy Sorry for late reply.
Show 12 quoted lines
> > On the Git mailing list, Duy Nguyen wrote (reply to this): > > I was a bit worried that the "test ! something" could be incorrectly > converted because for example, "test ! -d foo" is not always the same > as "test_path_is_missing". If "foo" is intended to be a file, then the > conversion is wrong. > > But I don't think you made any wrong conversion here. All these > negative "test" are preceded by "git rm" so the expectation is always > "test ! -e". >
Yes, I thought about it earlier and made changes thinking this only. Also when I was going through the code again, I replaced other conditionals `[ -f ]` with test_path_is_file etc.
Ciao Rohit