git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git 2.55.0 breaks revision path filtering with --no-walk

From
Kristofer Karlsson <krka@spotify.com>
Date
Jul 15, 2026, 21:09 UTC
Message-ID
<CAL71e4NjDTHbKR8z7pSrPpzDrX19JOTR04sArm7P=m5ivqkskA@mail.gmail.com>
In-Reply-To
<alfWF9cBPESuLBgS@earendel>
On Wed, 15 Jul 2026 at 20:48, Peter Colberg <pcolberg@redhat.com> wrote:
>
> Is the behaviour in Git 2.55.0 intentional, i.e., was --no-walk never
> intended to support path filtering, or is this indeed a regression?

Ouch, this definitely seems like a regression and it can be reproduced with a very simple scenario:

  git init repo && cd repo
  echo a >file-a && git add file-a && git commit -m "add file-a"
  echo b >file-b && git add file-b && git commit -m "add file-b"
  git rev-list --no-walk HEAD -- file-a

This should produce no output since HEAD only touches file-b, but with 2.55.0 it incorrectly outputs the commit.

I think you correctly identified the problematic change too, my refactoring indeed has a bug where process_parents() is skipped.

I think I can fix it, and also add test cases for this, but I am not sure what the immediate appropriate action is -- revert the entire patch or apply a bugfix? I think I can also try to check if there are other affected code paths that need additional test cases.

For what it's worth, I suspect the bugfix would look something like this, but I have not fully verified it yet.

in revision.c:
     case REV_WALK_NO_WALK:
    +        try_to_simplify_commit(revs, commit);
    +        break;
     case REV_WALK_LIMITED:

Thanks for the report, I will try to contribute a fix if possible, Kristofer

Previous: Peter Colberg
Message 2 of 2 in “Git 2.55.0 breaks revision path filtering with --no-walk”
  1. Peter ColbergJul 15, 2026
  2. Kristofer KarlssonJul 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.