Re: Git 2.55.0 breaks revision path filtering with --no-walk
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Jul 15, 2026, 21:09 UTC
- Message-ID
- <CAL71e4NjDTHbKR8z7pSrPpzDrX19JOTR04sArm7P=m5ivqkskA@mail.gmail.com>
- In-Reply-To
- <alfWF9cBPESuLBgS@earendel>
On Wed, 15 Jul 2026 at 20:48, Peter Colberg <pcolberg@redhat.com> wrote:
> > Is the behaviour in Git 2.55.0 intentional, i.e., was --no-walk never > intended to support path filtering, or is this indeed a regression?
Ouch, this definitely seems like a regression and it can be reproduced with a very simple scenario:
git init repo && cd repo echo a >file-a && git add file-a && git commit -m "add file-a" echo b >file-b && git add file-b && git commit -m "add file-b" git rev-list --no-walk HEAD -- file-a
This should produce no output since HEAD only touches file-b, but with 2.55.0 it incorrectly outputs the commit.
I think you correctly identified the problematic change too, my refactoring indeed has a bug where process_parents() is skipped.
I think I can fix it, and also add test cases for this, but I am not sure what the immediate appropriate action is -- revert the entire patch or apply a bugfix? I think I can also try to check if there are other affected code paths that need additional test cases.
For what it's worth, I suspect the bugfix would look something like this, but I have not fully verified it yet.
in revision.c:
case REV_WALK_NO_WALK:
+ try_to_simplify_commit(revs, commit);
+ break;
case REV_WALK_LIMITED:Thanks for the report, I will try to contribute a fix if possible, Kristofer