Re: [PATCH] rev-list: ignore replacements in the connectivity check

From: Kristofer Karlsson <krka@spotify.com>
Date: Nov 3, 2026, 10:51 UTC
Message-ID: <CAL71e4NYpaOqeXD2ZxgzM7g=7HiwEWoqBsPSTHd8NYJuPCHc0g@mail.gmail.com>
In-Reply-To: <CAOLa=ZTKaJhWHuKnSxL1pYN_JXdrr1Eohy8RepqFRc=Qph92Yg@mail.gmail.com>

On Tue, 3 Nov 2026 at 10:54, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 6 quoted lines

>
> Nit: Should we also modify 'Documentation/git-replace.adoc', which says:
>
>   Replacement references will be used by default by all Git commands
>   except those doing reachability traversal (prune, pack transfer and
>   fsck).

I think that sentence is actually more accurate with this patch than without it. The connectivity check runs as part of pack transfer (fetch and push), so until now that part of "pack transfer" did follow replacements, contrary to what the documentation says.

The list was never exhaustive either: index-pack, unpack-objects, commit-graph and multi-pack-index also disable replacements, so we can see it as a few examples of internal operations rather than a complete list.

Thanks, Kristofer