git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3070: skip ls-files tests with backslash patterns on Windows

From
Kristofer Karlsson <krka@spotify.com>
Date
May 29, 2026, 08:04 UTC
Message-ID
<CAL71e4MLyEEWtrHvB2K+stZUq6s+5sQUpSjmos3F9aVo3ej=Fw@mail.gmail.com>
In-Reply-To
<xmqqecivjn7k.fsf@gitster.g>
On Thu, 28 May 2026 at 22:26, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Two questions.
>
>  * Has this been broken on Windows since October, or has something
>    external change on Windows recently?  I do not know.  Anybody
>    knows?
>
>  * Is this change a workaround that sweeps ugly breakage under the
>    rug, or is backslash inherently unusable as an excape character
>    when handling paths on Windows (which I am afraid would make
>    wildmatch fairly useless there)?
>

I am fairly new to the git ecosystem as a developer (not as a user), so I am not sure how long this has been broken. The backslash patterns in the ls-files test path predate 8a6d158a - patterns like 'foo\*' and '[\-_]' have been there since de8bada2bf (2018) - so it may have been failing for a while before anyone noticed.

My thinking was that it would be good in general if the CI results were green and did not include false positives for errors that we know cannot work on this platform. The risk is that people stop looking into CI failures in detail because they start to assume it is the same old backslash problem.

That said, there is also a risk that the real underlying issue does not get fixed. I am hoping it is sufficient that the BSLASHPSPEC prereq and the case *\\* filter make it obvious to anyone reading the test what we are skipping over and why.

> Will queue.  Thanks.

Thanks! It felt a bit heavyweight to add noise to the list for trivial CI test changes but I suppose the process is the same even if it does not affect the production code.

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “t3070: skip ls-files tests with backslash patterns on Windows”
  1. t3070: skip ls-files tests with backslash patterns on WindowsKristofer Karlsson via GitGitGadget, May 28, 2026
  2. Junio C HamanoMay 28, 2026
  3. Kristofer KarlssonMay 29, 2026
  4. Junio C HamanoJun 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.