Re: Please review my code
- From
Оля Тележная <olyatelezhnaya@gmail.com>
- Date
- Jan 26, 2018, 19:34 UTC
- Message-ID
- <CAL21Bmnir6GSgZO2TqYZY8NByNuX+8O5BEyfh5URnawhRYPGFg@mail.gmail.com>
- In-Reply-To
- <CAP8UFD31oUtoPMN+S_r5YoKrSN4p_QgZQPE6dF20Wdf6o6vdJw@mail.gmail.com>
2018-01-26 19:42 GMT+03:00 Christian Couder <christian.couder@gmail.com>:
Show 17 quoted lines
> On Fri, Jan 26, 2018 at 11:32 AM, Оля Тележная <olyatelezhnaya@gmail.com> wrote: >> 2018-01-25 23:22 GMT+03:00 Christian Couder <christian.couder@gmail.com>: >>> On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote: >>>> Please look at my code: >>>> https://github.com/telezhnaya/git/commits/catfile >>>> You could send me any ideas here or in Github. >>> >>> I left some comments on GitHub. My main suggestion is to try to get >>> rid of the is_cat global and if possible to remove the "struct >>> expand_data *cat_file_info" global. >> >> Thanks for your comments, I find them very useful. Most of issues are >> fixed except the main one, that you mentioned here :) > > Ok, no problem, we will see what happens on the mailing list. > > It looks like the for-each-ref documentation has not been changed though.
Have you seen last commit? I updated cat-file documentation and I mentioned why I decided not to touch for-each-ref docs. Please share with me any ideas how can I make that place better.
> > Otherwise it looks good to me and perhaps you could send your series > to the mailing list even if it's long. For the first version, you may > want to add "RFC" in the subject of the patch emails you send.
Great, thanks, I will send it now. Olga
> > Thanks,