Re: [PATCH Outreachy 1/2] format: create pretty.h file

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Dec 9, 2017, 07:48 UTC
Message-ID: <CAL21BmmPNFAGnjtJy_ULBPjeU9HJAVx3x8B4ZrbqKaq_MU4W0Q@mail.gmail.com>
In-Reply-To: <xmqqr2s56jn6.fsf@gitster.mtv.corp.google.com>

> I see you've "standardized" to drop "extern" from the declarations
> in the header; I have an impression that our preference however is
> to go in the other direction.

OK, absolutely not a problem, I will return them. Do I need to write "extern" further in function declarations? And why did everyone choose writing "extern" every time? It looks obvious for me that declaration of function is extern, that's why I decided to throw them away.

> The choice of bits that are moved to the new header looks quite
> sensible to me.

I'm very happy and satisfied with it :-)

> s/futher/further/

It was a typo that I missed. Thank you! Will fix it also.

Show 8 quoted lines

> This has a toll on topics in flight that expect the symbols for
> pretty are available in "commit.h"; they are forced to include
> this new file they did not even know about.
>
> I notice that "commit.h" is included in "builtin.h"; perhaps adding
> a new include for "pretty.h" there would be of lessor impact?  I
> dunno.
>

It's a middle point, as I said. I have plans to create unifying format.h then (for all formatting issues). I guess that pretty.h and ref-filter.h will be deleted later. But, I really need to create now that pretty.h because it is much easier to work with existing interface. If you have another ideas how to achieve the main goal - please share them with me, I would appreciate that so much. I am not sure that my solution is the best, but I can't come up with something better for now.