git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] ref-filter: reduce memory leaks

From
Оля Тележная <olyatelezhnaya@gmail.com>
Date
Oct 9, 2018, 08:12 UTC
Message-ID
<CAL21BmkdUiNgr4NqpwTdi9f47i85s8oXCZMmVx5VyNKotL78uA@mail.gmail.com>

Reduce memory leaks in ref-filter.c. We still have leaks, but at least not so much.

I use command valgrind --leak-check=full -v ./git for-each-ref to check results.

Before: ==24727== LEAK SUMMARY: ==24727== definitely lost: 69,424 bytes in 724 blocks ==24727== indirectly lost: 29,643 bytes in 723 blocks ==24727== possibly lost: 120 bytes in 3 blocks ==24727== still reachable: 16,535 bytes in 185 blocks ==24727== suppressed: 0 bytes in 0 blocks ==24727== Reachable blocks (those to which a pointer was found) are not shown. ==24727== To see them, rerun with: --leak-check=full --show-leak-kinds=all ==24727== ==24727== ERROR SUMMARY: 107 errors from 107 contexts (suppressed: 0 from 0) ==24727== ERROR SUMMARY: 107 errors from 107 contexts (suppressed: 0 from 0)

After: ==16419== LEAK SUMMARY: ==16419== definitely lost: 17,144 bytes in 1,447 blocks ==16419== indirectly lost: 0 bytes in 0 blocks ==16419== possibly lost: 120 bytes in 3 blocks ==16419== still reachable: 16,217 bytes in 181 blocks ==16419== suppressed: 0 bytes in 0 blocks ==16419== Reachable blocks (those to which a pointer was found) are not shown. ==16419== To see them, rerun with: --leak-check=full --show-leak-kinds=all ==16419== ==16419== ERROR SUMMARY: 82 errors from 82 contexts (suppressed: 0 from 0) ==16419== ERROR SUMMARY: 82 errors from 82 contexts (suppressed: 0 from 0)

Travis build failed, but it also failed in master, so I guess it's not my fault. https://github.com/git/git/pull/538

Thank you! Olga

Message 1 of 1 in “ref-filter: reduce memory leaks”
  1. 0/3 ref-filter: reduce memory leaksОля Тележная, Oct 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.