Re: Rewrite cat-file.c : need help to find a bug

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Jan 4, 2018, 22:23 UTC
Message-ID: <CAL21BmkMrpEoijmMJ=2Y330shxABerc4tCBRpM2d4h0DypbYqA@mail.gmail.com>
In-Reply-To: <CAL21BmkcDK+VRc2CBTKnV5eubLh8u37THYjXhuTgFKR4Z=VtTA@mail.gmail.com>

2017-12-29 17:04 GMT+03:00 Оля Тележная <olyatelezhnaya@gmail.com>:

Show 7 quoted lines

> 2017-12-29 16:22 GMT+03:00 Jeff King <peff@peff.net>:
>> On Fri, Dec 29, 2017 at 01:05:50PM +0300, Оля Тележная wrote:
>>
>>> Hi everyone,
>>> I am trying to reuse formatting logic from ref-filter in cat-file
>>> command. Now cat-file uses its own formatting code.
>>> I am trying to achieve that step-by-step,

Happy to say that my previous bug is fixed, and I am struggling with the next one. Now I want to get rid of using expand_data structure (I took it from cat-file.c to simplify migrating process and now it's time to delete it).

>>> My code is here.
>>> https://github.com/telezhnaya/git/commits/catfile
>>> All commits that starts from "cat-file: " are successfully passing all tests.

So for now 2 of my last commits fail, and I am tired of searching for the error. I was also trying to leave cat_file_info variable and fill in both new and old variables and then compare resulting values by printing them into file. Everything is OK, but I find it dudpicious that the resulting file is too small (fprintf was invoked only 3 times, it was here: https://github.com/telezhnaya/git/commit/54a5b5a0167ad634c26e4fd7df234a46286ede0a#diff-2846189963e8aec1bcb559b69b7f20d0R1489)

I have left few comments in github to simplify your understanding what I was trying to achieve. Feel free to ask any questions if you find the code strange, unclear or suspicious. Thanks!

Olga