Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function

From: Ronnie Sahlberg <sahlberg@google.com>
Date: May 22, 2014, 16:49 UTC
Message-ID: <CAL=YDW=g=5ux4tThcK3EEmPuzqmwGBX+7au4MMWnfL_NLq897A@mail.gmail.com>
In-Reply-To: <20140521220710.GG12314@google.com>

On Wed, May 21, 2014 at 3:07 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 18 quoted lines

> Ronnie Sahlberg wrote:
>
>> +++ b/refs.c
> [...]
>> @@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction *transaction,
>>               struct ref_update *update = updates[i];
>>
>>               if (!is_null_sha1(update->new_sha1)) {
>> -                     ret = update_ref_write(msg,
>> -                                            update->refname,
>> -                                            update->new_sha1,
>> -                                            update->lock, err,
>> -                                            UPDATE_REFS_QUIET_ON_ERR);
>> +                     ret = write_ref_sha1(update->lock, update->new_sha1,
>> +                                          msg);
>
> This changes the return value on error from 1 to -1.  That seems like a
> good change.  It's probably worth mentioning in the commit message.

Done.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.