Re: [PATCH v3 2/2] config: move pack size limit into repo config
- From
- Tanga Joris <tangajoris@gmail.com>
- Date
- Nov 5, 2026, 15:14 UTC
- Message-ID
- <CAKrRMNqzOX=vUUMrMf5P_Atar8_qCSbGdtBktfT+iL4hJfFX-Q@mail.gmail.com>
- In-Reply-To
- <ba34e82a0a6a99181637e2fe33be5506f2a1bdd0.1793710118.git.gitgitgadget@gmail.com>
Hello Joy,
Thanks for the new version.
I fetched v3 with the Fetch-It-Via line and built it. t1300, t5300 and t7700 pass, and pack.packSizeLimit still works: with "-c pack.packSizeLimit=1m", "git repack -ad" on three 700 kB files gives three packs.
One thing you may not have seen: Junio has a patch, "repo_config_values: freeze the structure for now" [1], resent to the list on 3 November. It adds a comment to struct repo_config_values saying not to add any new members until it can work on a repository other than the_repository, and Patrick acked it. It is in 'seen' as jc/freeze-repo-config-values, and 2/2 goes against what that comment asks.
Separately, v3 does not merge cleanly with 'seen' because object-file.c conflicts with Christian's cc/pack-index-v3.
On Tue, 3 Nov 2026 at 16:14, Joy Gundu via GitGitGadget <gitgitgadget@gmail.com> wrote:
> + unsigned long pack_size_limit;
Since 2/2 adds a member to that structure, I think it cannot go in like this for now. 1/2 does not add one, so maybe it could be sent on its own? Christian or Usman probably know better what to do next.
Two small things in case you send another version. 1/2 leaves two blank lines in a row in repo_config_values_init(), and 2/2 removes one of them, so that fix belongs in 1/2. And the cover letter still says "Changes since v1" and lists the v1 to v2 changes, so it does not say what changed in v3.
[1] https://lore.kernel.org/git/xmqq1p917kwl.fsf@gitster.g/
Thanks, Tanga