Re: [PATCH v1] hash: handle invalid algorithms when formatting object IDs
- From
- Tanga Joris <tangajoris@gmail.com>
- Date
- Nov 7, 2026, 20:22 UTC
- Message-ID
- <CAKrRMNqBCiH06xsre-YafBJiqPTiBgPnNZ3xPrhjTQWU3czwHg@mail.gmail.com>
- In-Reply-To
- <au0ZOsuyo0YYyZsa@fruit.crustytoothpaste.net>
Hi brian,
Thank you for jumping in.
On Fri, 6 Nov 2026 at 03:03, brian m. carlson <sandals@crustytoothpaste.net> wrote:
> Minor nit: I use they/them pronouns.
I'm really sorry for getting your pronouns wrong.
Show 11 quoted lines
> This is not a valid configuration. I have a patch on my sha256-interop > branch, 5b208e4a3d34ffba0fbeafe991643d6d47a5caa0, that should make the > members not public. It depends partially on things other in that > series, but it should be fine to drop those pieces if you want to pick > that up and send it in. > > If you pass the structure from C, it's intended that it panics if algo > is zero. That's because we don't want to rely on the behaviour of > depending on a mutable global in Rust, since that's unsafe and leads to > action at a distance. We really should just drop that fallback and fix > all of the relevant callers at some point.
That makes sense. I didn't know algo 0 coming from C is meant to panic in Rust, rather than depend on the default hash.
Since this is shrimech's thread, I think shrimech could pick up 5b208e4a3d (making the ObjectID members private), and I'd be happy to review it.
Could you also push 5b208e4a3d somewhere public? I could not fetch it from https://github.com/bk2204/git, whose sha256-interop branch seems to have an older version (c38d0c8475, "rust: don't expose the internals of ObjectID"). That would make it easier for shrimech to pick up.
Thanks, Tanga