git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH v3 1/2] parse-options: answer --git-completion-helper before command runs

From
TJTanga Joris <tangajoris@gmail.com>
Date
Nov 4, 2026, 22:34 UTC
Message-ID
<CAKrRMNpaF=NQOi0mmr_1jE0TQynbQRzhEtdSj2RLfon-UHMLgw@mail.gmail.com>
In-Reply-To
<20261103092503.14872-1-herroyalpriestess@gmail.com>
Hey Cynthia,
Thank you for testing this.
On Tue, 3 Nov 2026 at 12:25, Cynthia Uche <herroyalpriestess@gmail.com> wrote:
> The new t9300 test fails without the parse-options.c change, so it
> guards the fix, but it only covers the plain form: with the "-all"
> branch changed to show_gitcomp(opts, 0) it still passes. Could you
> add a test for that branch?

Yes, I will add the test in my v4. I have tried it locally myself and it passes with my fix and fails when the -all branch is broken. Thanks again, I will credit you with Helped-by:.

Tanga
Previous: Cynthia UcheNext: Tanga Joris
Message 15 of 18 in “git.c: drop NO_PARSEOPT from builtins that use parse-options”
  1. git.c: drop NO_PARSEOPT from builtins that use parse-optionsTanga Joris, Oct 24, 2026
  2. René ScharfeOct 25, 2026
  3. Tanga JorisOct 26, 2026
  4. Junio C HamanoOct 26, 2026
  5. 1/2 fast-import: handle --git-completion-helper before reading inputTanga Joris, Oct 29, 2026
  6. 2/2 git.c: drop NO_PARSEOPT from builtins that use parse-optionsTanga Joris, Oct 29, 2026
  7. Junio C HamanoOct 29, 2026
  8. 1/2 parse-options: answer --git-completion-helper before command runsTanga Joris, Oct 29, 2026
  9. 2/2 git.c: drop NO_PARSEOPT from builtins that use parse-optionsTanga Joris, Oct 29, 2026
  10. Kaartic SivaraamOct 30, 2026
  11. Tanga JorisNov 2, 2026
  12. Kaartic SivaraamOct 30, 2026
  13. Tanga JorisOct 31, 2026
  14. Cynthia UcheNov 3, 2026
  15. Tanga JorisNov 4, 2026
  16. 1/3 parse-options: answer --git-completion-helper before command runsTanga Joris, Nov 5, 2026
  17. 2/3 git.c: drop NO_PARSEOPT from builtins that use parse-optionsTanga Joris, Nov 5, 2026
  18. 3/3 t0012: catch builtins that keep NO_PARSEOPT after conversionTanga Joris, Nov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.