Re: [PATCH v3] path.c enter_repo(): fix unproper strbuf unwrapping and memory leakage

From: 惠轶群 <huiyiqun@gmail.com>
Date: Mar 29, 2016, 02:38 UTC
Message-ID: <CAKqreux6XLMGN151fn6xN5PeNURLLWjdBVNjKHLzWOjAm45YOg@mail.gmail.com>
In-Reply-To: <xmqqwpomxz4v.fsf@gitster.mtv.corp.google.com>

2016-03-29 1:58 GMT+08:00 Junio C Hamano <gitster@pobox.com>:

Show 23 quoted lines

> Hui Yiqun <huiyiqun@gmail.com> writes:
>
>> According to strbuf.h, strbuf_detach is the sole supported method
>> to unwrap a memory buffer from its strbuf shell.
>> ...
>> diff --git a/path.c b/path.c
>> index 969b494..9801617 100644
>> --- a/path.c
>> +++ b/path.c
>> @@ -625,6 +625,7 @@ const char *enter_repo(const char *path, int strict)
>>  {
>>       static struct strbuf validated_path = STRBUF_INIT;
>>       static struct strbuf used_path = STRBUF_INIT;
>> ...
>> +return_null:
>> +     free(dbuf);
>> +     strbuf_release(&used_path);
>> +     strbuf_release(&validated_path);
>>       return NULL;
>>  }
>
> I see these strbuf's are "static" storage class, so that they do not
> have to get freed.

I see, thanks.