git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6] Add an explicit GIT_DIR to the list of excludes

From
PBPasha Bolokhov <pasha.bolokhov@gmail.com>
Date
Jun 13, 2014, 16:10 UTC
Message-ID
<CAKpPgvf=OGRHFv81x2b_PVqzALbSWHaJvejyy5w7aS_P+QFA6w@mail.gmail.com>
In-Reply-To
<53994667.90209@kdbg.org>
Show 7 quoted lines
>> +             test_cmp status.actual.2 status.expect.2
>
> It is customary to call the files 'expect' and 'actual'. Furthermore,
> swap the order so that in case of a failure the diff shows how the
> actual text was changed from the expected text:
>
>                 test_cmp status.expect.2 status.actual.2

So, is naming the files "status.expect.2" instead of just "expect"/"actual" ok or not? Those prefixes "status" etc just help sorting out where the problem lies that causes the test to fail. But let me know if this is too "detailed"

>
> Moreover, test_*_fail helpers are intended to be used only with git
> commands; we don't expect system commands to fail in unexpected ways.

Ok, no problem, will change that. The only thing, I saw this in other tests, so decided to use it too. Those tests use "test_mighf_fail rm" and "ls" seemingly without invocation of git

Previous: Johannes SixtNext: Junio C Hamano
Message 7 of 10 in “Add an explicit GIT_DIR to the list of excludes”
  1. Add an explicit GIT_DIR to the list of excludesPasha Bolokhov, Jun 4, 2014
  2. Duy NguyenJun 8, 2014
  3. Pasha BolokhovJun 10, 2014
  4. Duy NguyenJun 11, 2014
  5. Add an explicit GIT_DIR to the list of excludesPasha Bolokhov, Jun 11, 2014
  6. Johannes SixtJun 12, 2014
  7. Pasha BolokhovJun 13, 2014
  8. Junio C HamanoJun 13, 2014
  9. Add an explicit GIT_DIR to the list of excludesPasha Bolokhov, Jun 14, 2014
  10. Add an explicit GIT_DIR to the list of excludesPasha Bolokhov, Jun 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.