Re: [PATCH] fix revisions doc about quoting for ':/' notation

From: ryenus <ryenus@gmail.com>
Date: Aug 17, 2017, 07:01 UTC
Message-ID: <CAKkAvay1gJTLJrGLb3aFMJmnyQjPhSD9cx0DRAAN3Mh5NAhfiQ@mail.gmail.com>
In-Reply-To: <xmqqo9rfi3b2.fsf@gitster.mtv.corp.google.com>

On 17 August 2017 at 05:57, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Andreas Heiduk <asheiduk@gmail.com> writes:
>
>> Am 16.08.2017 um 05:21 schrieb ryenus:
>>> To make sure the `<text>` in `:/<text>` is seen as one search string,
>>> one should quote/escape `<text>` properly.
>>>
>>> Especially, the example given in the manual `:/fix nasty bug` does not
>>> work because of missing quotes. The examples are now corrected, and a
>>> note about quoting/escaping is added as well.
>>
>> Right now the documentation describes the syntax as git sees the
>> parameters. This is agnostic of the shell or other UI with their
>> different quoting rules.  For example users of fish must quote
>> `rev@{2}`. A GUI might require no quoting at all. In that case `:/"fix
>> nasty bugs"` would be given to git verbatim and hence not find the revision.
>
> These are all good points that I didn't consider when responding.
>

Makes sense for me, too. I've just sent a v2 patch, which leaves the original example as-is, meanwhile added a example inside the explanation.

Thanks!