git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] unpack-trees.c: handle empty deleted ita files

From
Varun Naik <vcnaik94@gmail.com>
Date
Aug 15, 2019, 16:17 UTC
Message-ID
<CAK_rgsGSfL2zQLP59O+PUCLGz0X8c4UQ3Zg=9M+nCww5C+X_gA@mail.gmail.com>
In-Reply-To
<xmqqr25o7qmf.fsf@gitster-ct.c.googlers.com>
On Tue, Aug 13, 2019 at 1:33 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
>
> The original code considered that two entries with the same mode and
> the same "contents" are the same.  As nobody sane tracks an empty
> file for an extended span of history, that meant that most of the
> time, intent-to-add entries, which has the normal mode bits for the
> blobs (with or without the executable bit) and object name for a
> zero length blob, would have been judged "different".
>
I agree, this edge case is really arcane. The rabbit hole was deep :)
Show 7 quoted lines
> So perhaps
>
> +       !ce_intent_to_add(a) && !ce_intent_to_add(b) &&
>
> i.e. "a cache entry is eligible to be same with something else only
> when its I-T-A bit is unset".
>
I decided to follow René's suggestion in response to this. Patch coming soon.
Varun
Previous: René ScharfeNext: Junio C Hamano
Message 5 of 12 in “unpack-trees.c: handle empty deleted ita files”
  1. unpack-trees.c: handle empty deleted ita filesVarun Naik, Aug 13, 2019
  2. René ScharfeAug 13, 2019
  3. Junio C HamanoAug 13, 2019
  4. René ScharfeAug 14, 2019
  5. Varun NaikAug 15, 2019
  6. Junio C HamanoAug 15, 2019
  7. Varun NaikAug 19, 2019
  8. Junio C HamanoAug 19, 2019
  9. unpack-trees.c: distinguish ita files from empty filesVarun Naik, Aug 15, 2019
  10. René ScharfeAug 15, 2019
  11. unpack-trees.c: distinguish ita files from empty filesVarun Naik, Aug 21, 2019
  12. unpack-trees.c: distinguish ita files from empty filesVarun Naik, Feb 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.