git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] git-gui: fix hunk parsing for corner case changes

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Jan 14, 2012, 05:25 UTC
Message-ID
<CAKPyHN3dp_t+hVsX_dBB8OnU=oM2t1DsdKFDghD7L9qAEtYgfg@mail.gmail.com>
In-Reply-To
<cccd6193cf3bfe170e14270204d735a842bb8563.1326116492.git.bert.wesarg@googlemail.com>
Hi Pat,
On Mon, Jan 9, 2012 at 14:43, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
Show 24 quoted lines
> The simple hunk parsing code did not recognize hunks when there is no
> second number after the comma. Like in these cases:
>
>  @@ -1 +0,0 @@
>  -1
>
> Which resulted in this hunk header:
>
>  @@ -1 +0,1 +1 +0,0 @@
>
> Or:
>
>  @@ -1 +1 @@
>  -1
>  +2
>
> Resulted in:
>
>  @@ -1 +1 @@
>  ,1 +1 +1 @@
>  ,0 @@
>
> While trying to stage only the '-1' line.
>

could you please consider pushing this into the 1.7.9 release. I see no point in waiting for the next release.

Thanks.
Bert
Previous: Bert Wesarg
Message 8 of 8 in “git-gui: fix hunk parsing for corner case changes”
  1. 1/1 git-gui: fix hunk parsing for corner case changesBert Wesarg, Jan 9, 2012
  2. 2/2 git-gui: fix applying line/ranges when the selection ends at the begin of a lineBert Wesarg, Jan 9, 2012
  3. 3/3 git-gui: support for reverting hunks and linesBert Wesarg, Jan 9, 2012
  4. Bert WesargJan 14, 2012
  5. Junio C HamanoJan 14, 2012
  6. Bert WesargJan 14, 2012
  7. Bert WesargJan 14, 2012
  8. Bert WesargJan 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.