Re: [RFC/PATCH] grep --no-index: allow to grep without git exclusions

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Jul 21, 2011, 17:23 UTC
Message-ID: <CAKPyHN3dRyrpW_3emC1s8eDWTF_hSGEY9p+Ojio3NzvNP2hOsg@mail.gmail.com>
In-Reply-To: <7v62mv4n93.fsf@alter.siamese.dyndns.org>

2011/7/21 Junio C Hamano <gitster@pobox.com>:

Show 11 quoted lines

> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>
>> It should be. But I think that unveils one of the shortcomings of the
>> (any) option parser: You wont get notified when an option was given,
>> regardless of its value. To handle the above I would have to use
>> OPTION_CALLBACK to set an addition flag exc_given (like it is done in
>> git-ls-files) and test against this.
>
> Prepare a three-value variable, initialized to -1, set it to 0 on --no-foo
> and set it to 1 on --foo. Use the default if the variable is still -1.
>

Thats the 'invent an invalid value'-case I described. Which does not necessarily exist.

Having the proposed 'given' flag available I would need only one variable for all the options (these coming from ls-files) to check if any of them where given, and could decide if the given options would make sense.

Bert