Re: [PATCH v2] gc: recommend `git gc --prune=now` instead of `git prune`

From: 林自均 <johnlinp@gmail.com>
Date: Jun 10, 2020, 03:43 UTC
Message-ID: <CAKO26MuO6UR8c5U+WX0ayEJjmXEnsp9P=ujZGwasM7KbrUgcRw@mail.gmail.com>
In-Reply-To: <xmqqa71ci5vd.fsf@gitster.c.googlers.com>

Hi all,

Thank you Bjarmason & Junio. If Denton doesn't have other concerns, I'll start working on adding bash completion for "git prune".

Best, John Lin

Junio C Hamano <gitster@pobox.com> 於 2020年6月10日 週三 上午12:03寫道：

Show 23 quoted lines

>
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
> > On Tue, Jun 09 2020, John Lin via GitGitGadget wrote:
> >
> >> From: John Lin <johnlinp@gmail.com>
> >>
> >> `git prune` is a plumbing command and should not be run directly by
> >> users. The corresponding porcelain command is `git gc`, which is
> >> mentioned in the man page of `git prune`.
> >
> > This change feels incomplete without a change to git-prune's
> > documentation, see 8d308b3540 ("Documentation: point git-prune users to
> > git-gc", 2008-04-29).
> >
> > I.e. it still talks about "in most cases you shouldn't run this", but
> > here we are removing a case where it would otherwise make sense because
> > the user shouldn't use it directly.
> >
> > I think instead the small change that makes the most sense here is to
> > just add "prune" to completions,...
>
> That's perfectly reasonable stance to take.