Re: [PATCH 1/1] status: remove the empty line after hints
- From
林自均 <johnlinp@gmail.com>
- Date
- May 28, 2019, 23:08 UTC
- Message-ID
- <CAKO26Ms6_rJfq6knh14H1O-V2_6v8YxYdjah0vTdvpJTc7hdXw@mail.gmail.com>
- In-Reply-To
- <xmqq36ky1fe8.fsf@gitster-ct.c.googlers.com>
Hi Junio,
Junio C Hamano <gitster@pobox.com> 於 2019年5月29日 週三 上午4:41寫道:
Show 30 quoted lines
> > 林自均 <johnlinp@gmail.com> writes: > > > Hi Junio, > > > > John Lin via GitGitGadget <gitgitgadget@gmail.com> 於 2019年5月15日 週三 下午6:54寫道: > >> > >> From: John Lin <johnlinp@gmail.com> > >> > >> Before this patch, there is inconsistency between the status > >> messages with hints and the ones without hints: there is an > >> empty line between the title and the file list if hints are > >> presented, but there isn't one if there are no hints. > >> > >> This patch remove the inconsistency by removing the empty > >> lines even if hints are presented. > > > > I would like to ask for the final decision on this patch. Thank you. > > If I recall correctly, the test part of this patch conflicts badly > with a topic in flight that splits 'checkout' into 'restore' and > 'switch', which is a more important topic between the two. So if I > must give _the final_ decision, then we need to drop this patch, but > I'd rather not ;-) > > Doing this change on top of the switch/restore topic, once it > stabilized more and graduated to 'master', would be the best course > of action, I would think. > > Thanks.
I see. Thanks for your kind explanation. I'll wait for the switch/restore topic to merge into master.
Best, John Lin