default editor

While downloading git, I was asked to name a default editor, which I did: ed. from cygwin. It worked in the enuing test, but was rejected because it returned an error. I suppose this is because cygwin return conventions are those of Unix, not Windows. That raises the question: does it matter? Does any other part of git depend on the editor's return value?