git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Call to_utf8() on input string in chop_and_escape_str()

From
Jürgen Kreileder <jk@blackdown.de>
Date
Nov 29, 2011, 21:41 UTC
Message-ID
<CAKD0Uuy8y7Dc6gfvYVe-FJ=Reiu0M3wOY4r4VVPtEYmahZcdwA@mail.gmail.com>

a) To fix the comparison with the chopped string b) To give the title attribute correct encoding

Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
---
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..4237ea6 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1695,11 +1695,11 @@ sub chop_and_escape_str {
 	my ($str) = @_;

 	my $chopped = chop_str(@_);
-	if ($chopped eq $str) {
+	if ($chopped eq to_utf8($str)) {
 		return esc_html($chopped);
 	} else {
 		$str =~ s/[[:cntrl:]]/?/g;
-		return $cgi->span({-title=>$str}, esc_html($chopped));
+		return $cgi->span({-title => to_utf8($str)}, esc_html($chopped));
 	}
 }
-- 
1.7.5.4
Next: Jakub Narebski
Message 1 of 3 in “gitweb: Call to_utf8() on input string in chop_and_escape_str()”
  1. gitweb: Call to_utf8() on input string in chop_and_escape_str()Jürgen Kreileder, Nov 29, 2011
  2. Jakub NarebskiNov 29, 2011
  3. Jürgen KreilederNov 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.