Re: Patch that modifies git usage message
- From
Alangi Derick <alangiderick@gmail.com>
- Date
- May 1, 2015, 15:54 UTC
- Message-ID
- <CAKB+oNtsy4E5Y6d3VCvdrjRTsdqARu8nJPYjH5J-qUenirR8mg@mail.gmail.com>
- In-Reply-To
- <CAGZ79kY1ZoYrVwVVqfyB+uMGsJo59qDxbDLgyo5qygSm=CUVhA@mail.gmail.com>
I am saying so because there are some strings with upper case letters and others with lower case letters. So there is no consistency. That is why i wanted to keep the consistency by correcting the letters which are to be corrected and allow the once which are to be allowed. Regards Alangi Derick Ndimnain
On Fri, May 1, 2015 at 4:51 PM, Stefan Beller <sbeller@google.com> wrote:
Show 30 quoted lines
> On Fri, May 1, 2015 at 4:01 AM, Alangi Derick <alangiderick@gmail.com> wrote: >> This patch just modifies the "usage" word to "Usage" which enhances >> readability. Below is the patch >> >> Regards >> Alangi Derick Ndimnain > > It's easier to have the patch in the email itself, this looks it's > some form of attachment. > > Checkout Documentation/SubmittingPatches (protip: get "git send-email" > working, it will > send in the preferred way by default for nearly any open source > project using email based > workflows.) > > There are also some resources on the web, how to send patches, > although it should be > all covered in our Documentation, > http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html > > For the patch itself: > > $ grep -r usage *.c builtin/*.c |wc -l > 551 > $ grep -r Usage *.c builtin/*.c |wc -l > 3 > > The community agreed (maybe subconciously) to prefer lower case > for the 'usage' string, so I don't think this is an improvement.