Re: Change on check-attr behavior

From: Sérgio Peixoto <sergio.peixoto@gmail.com>
Date: Jan 18, 2019, 09:41 UTC
Message-ID: <CAK3b1GJPZ5X3uEP1a-NF9PZkE0tTKVLda5hM32jExVz_OD2E=g@mail.gmail.com>
In-Reply-To: <20190117160752.GA29375@sigill.intra.peff.net>

Create a file  .git/info/attributes with contents

If the contents are: [attr]allowed-ext *.py allowed-ext=100

then the problem occurs.

If contents are: #[attr]allowed-ext *.py allowed-ext=100

the problem is gone

On Thu, Jan 17, 2019 at 4:07 PM Jeff King <peff@peff.net> wrote:

Show 35 quoted lines

>
> On Thu, Jan 17, 2019 at 03:47:09PM +0000, Sérgio Peixoto wrote:
>
> > I think there is a bug on the check-attr behavior of git when asking
> > for the "allowed-ext" attribute.  Check the logs below to see that
> > with version  2.20.1.windows.1 we get unspecified even the attribute
> > is there as you can see when asking for all the attributes.
> >
> > === OLD VERSION ===
> > > git version
> > git version 2.8.1.windows.1
> >
> > > git check-attr -a test.py
> > test.py: text: set
> > test.py: allowed-ext: 100
> >
> > > git check-attr allowed-ext test.py
> > test.py: allowed-ext: 100
> >
> > === NEW VERSION ===
> > > git --version
> > git version 2.20.1.windows.1
> >
> > > git check-attr -a test.py
> > test.py: text: set
> > test.py: allowed-ext: 100
> >
> > > git check-attr allowed-ext test.py
> > test.py: allowed-ext: unspecified
>
> I can't reproduce here (on Linux, but I don't think the attr code is
> particularly Windows-specific).  Can you show us what's in your
> .gitattributes file(s)?
>
> -Peff