Re: [PATCH] Replace memcpy with hashcpy when dealing hash copy globally

From: He Sun <sunheehnus@gmail.com>
Date: Mar 1, 2014, 14:55 UTC
Message-ID: <CAJr59C3Lc_NrXNVT8aB9CThQRZvakBJWVVghf0M7S0z0qSN=DA@mail.gmail.com>
In-Reply-To: <CALUzUxo=5aUCjL0GDz=3JjuQqN4+9pTPbmNWO3Rda+UuLDOYhQ@mail.gmail.com>

Got it. Thanks.

2014-03-01 17:13 GMT+08:00 Tay Ray Chuan <rctay89@gmail.com>:

Show 22 quoted lines

> On Sat, Mar 1, 2014 at 10:58 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>> On Sat, Mar 1, 2014 at 8:07 AM, Sun He <sunheehnus@gmail.com> wrote:
>>> Signed-off-by: Sun He <sunheehnus@gmail.com>
>>> ---
>>>  Find the potential places with memcpy by the bash command:
>>>    $ find . | xargs grep "memcpy.*\(.*20.*\)"
>>>
>>>  Helped-by: Michael Haggerty<mhagger@alum.mit.edu>
>>
>> You may want to put this Helped-by before "---" because it's supposed
>> to end up in the final commit.
>
> To elaborate further: anything below the three-dash is ignored when
> the patch is applied. So it doesn't show up in the commit at all. I
> don't really know the reason for this - probably a patch (1) thing.
>
> You could put the patch the Helped-by before your Signed-off-by
> (sometimes referred to as S-o-b).
>
> --
> Cheers,
> Ray Chuan