Re: [PATCH] OPTION_CMDMODE should be used when not accept an argument, and OPTION_NUMBER is of special type. So change the mode to OPTION_CMDMODE

From: He Sun <sunheehnus@gmail.com>
Date: Feb 28, 2014, 23:50 UTC
Message-ID: <CAJr59C097u0HK5RqmZj6rUTAgeoSMjpoCJR_NGHiot02tQHDMg@mail.gmail.com>
In-Reply-To: <xmqqsir3t39f.fsf@gitster.dls.corp.google.com>

2014-03-01 4:02 GMT+08:00 Junio C Hamano [via git] <ml-node+s661346n7604560h61@n2.nabble.com>:

Show 17 quoted lines

> Duy Nguyen <[hidden email]> writes:
>
>> Way too long subject line. Keep it within 70-75 chars. The rest could
>> be put in the body.
>>
>> On Fri, Feb 28, 2014 at 9:32 PM, 孙赫 <[hidden email]> wrote:
>>> I am not sure if this is a bug.
>>> I need your help to find out it.
>>
>> Tip:git has a wonderful history (most of it anyway). Try "git log
>> --patch parse-options.[ch]" to understand parse-options evolution. Add
>> -SOPTION_NUMBER (or -SOPTION_CMDMODE) to limit to only commits whose
>> diff contains that keyword.
>
> Also, I do not think this should be done in a single patch.  What if
> it turns out that explicitly making sure that CMDMODE does not take
> any argument is a good idea, but the other change is a bad one?

OK, I will try to figure it out.

Show 14 quoted lines

> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to [hidden email]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
> ________________________________
> If you reply to this email, your message will be added to the discussion
> below:
> http://git.661346.n2.nabble.com/PATCH-OPTION-CMDMODE-should-be-used-when-not-accept-an-argument-and-OPTION-NUMBER-is-of-special-typeE-tp7604513p7604560.html
> To start a new topic under git, email
> ml-node+s661346n661346h27@n2.nabble.com
> To unsubscribe from git, click here.
> NAML