git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 20/21] signed push: add "pushee" header to push certificate

From
Shawn Pearce <spearce@spearce.org>
Date
Sep 4, 2014, 21:13 UTC
Message-ID
<CAJo=hJsd8wfqvxBMThwh76BqTD9eZza98PRKOfgtr=-eQkUh3A@mail.gmail.com>
In-Reply-To
<1409861097-19151-21-git-send-email-gitster@pobox.com>
On Thu, Sep 4, 2014 at 1:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Record the URL of the intended recipient for a push (after
> anonymizing it if it has authentication material) on a new "pushee
> URL" header.  Because the networking configuration (SSH-tunnels,
> proxies, etc.) on the pushing user's side varies, the receiving
> repository may not know the single canonical URL all the pushing
> users would refer it as (besides, many sites allow pushing over
> ssh://host/path and https://host/path protocols to the same
> repository but with different local part of the path).  So this
> value may not be reliably used for replay-attack prevention
> purposes, but this will still serve as a human readable hint to
> identify the repository the certificate refers to.

Well, a push cert validator could require the pushee use specific URL(s) known to it. The server operator knows their URL space and could just demand that users use ssh://host/path and https://host/path and nothing fancy like aliases in ~/.ssh/config.

But I think you are right to punt on that and let the cert validator hook written by the server operator to decide if pushee should be verified.

Previous: Junio C HamanoNext: Junio C Hamano
Message 22 of 23 in “Signed push”
  1. 00/21 Signed pushJunio C Hamano, Sep 4, 2014
  2. 01/21 receive-pack: do not overallocate command structureJunio C Hamano, Sep 4, 2014
  3. 02/21 receive-pack: parse feature request a bit earlierJunio C Hamano, Sep 4, 2014
  4. 03/21 receive-pack: do not reuse old_sha1[] for other thingsJunio C Hamano, Sep 4, 2014
  5. 04/21 receive-pack: factor out queueing of commandJunio C Hamano, Sep 4, 2014
  6. 05/21 send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higherJunio C Hamano, Sep 4, 2014
  7. 06/21 send-pack: refactor decision to send update per refJunio C Hamano, Sep 4, 2014
  8. 07/21 send-pack: always send capabilitiesJunio C Hamano, Sep 4, 2014
  9. 08/21 send-pack: factor out capability string generationJunio C Hamano, Sep 4, 2014
  10. 09/21 receive-pack: factor out capability string generationJunio C Hamano, Sep 4, 2014
  11. 10/21 send-pack: rename "new_refs" to "need_pack_data"Junio C Hamano, Sep 4, 2014
  12. 11/21 send-pack: refactor inspecting and resetting status and sending commandsJunio C Hamano, Sep 4, 2014
  13. 12/21 send-pack: clarify that cmds_sent is a booleanJunio C Hamano, Sep 4, 2014
  14. 13/21 gpg-interface: move parse_gpg_output() to where it should beJunio C Hamano, Sep 4, 2014
  15. 14/21 gpg-interface: move parse_signature() to where it should beJunio C Hamano, Sep 4, 2014
  16. 15/21 pack-protocol doc: typofix for PKT-LINEJunio C Hamano, Sep 4, 2014
  17. 16/21 push: the beginning of "git push --signed"Junio C Hamano, Sep 4, 2014
  18. 17/21 receive-pack: GPG-validate push certificatesJunio C Hamano, Sep 4, 2014
  19. 18/21 send-pack: send feature request on push-cert packetJunio C Hamano, Sep 4, 2014
  20. 19/21 signed push: remove duplicated protocol infoJunio C Hamano, Sep 4, 2014
  21. 20/21 signed push: add "pushee" header to push certificateJunio C Hamano, Sep 4, 2014
  22. Shawn PearceSep 4, 2014
  23. 21/21 signed push: fortify against replay attacksJunio C Hamano, Sep 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.